Skip to content

Conversation

stjhimy
Copy link

@stjhimy stjhimy commented Aug 10, 2021

  • Exclude "s3 external" tests by default since it requires having a key/secret and an active internet connection to run. Those tests are still runnable using mix test --include external.
  • Add ExAws.Operation tests: This will only test the ExAws.Operation building process, checking params etc It can run without internet connection.
  • Add a basic usage example on the README so new users can see at first glance how easy is to use it.

Let me know if the operation tests are useful and I can complete the testing before merging.
Thanks a lot for the package, it's been extensively used and very helpful.

@andreragsilva
Copy link
Contributor

@stjhimy thank you for the contribution 🙏

I am quite busy at the moment, so I will be reviewing the PR on Friday 🤞

Copy link
Contributor

@andreragsilva andreragsilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the help @stjhimy, it definitely improves the testing structure 🙌

I did start something similar within branch feature/add-missing-actions but I didn't finish since the branch contains issue #13.

@andreragsilva
Copy link
Contributor

andreragsilva commented Sep 20, 2021

To answer your question, the tests are useful and there will be more Operation Actions that will require testing as well. Please check the branch I mentioned above and feel free to contribute.

Sorry for the delay, have been a couple busy weeks 👍

@stjhimy
Copy link
Author

stjhimy commented Sep 27, 2021

Great @andreragsilva!
I will have a look at the branch this week and see if I can move on with #13 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants