release `8.0.0a1` to PyPI (DM-3062) #2387

haakonvt · 2025-10-30T12:34:38Z

Note to reviewer:

Commit history is clean - please review commit-by-commit!
Github only shows the most recent 250 commits, and this PR boasts 300+ ( ), so you need to review those outside the UI 🕺

gemini-code-assist · 2025-10-30T12:34:42Z

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

amorken · 2025-11-05T12:16:18Z

/gemini review
(lol)

gemini-code-assist

Code Review

This pull request introduces a major version bump to 8.0.0a0, with the primary change being the introduction of full asynchronous support using httpx. This is a significant and well-executed refactoring that makes almost all API methods async. The SDK is now async-first, with a synchronous CogniteClient wrapping the new AsyncCogniteClient for backward compatibility. In addition to the async refactoring, this PR removes several deprecated methods and parameters, such as the generic aggregate and filter methods, and the partitions parameter in most __call__ methods. It also improves some APIs, like insert_dataframe which now infers identifier types. All these breaking changes are clearly documented in the updated MIGRATION_GUIDE.md. The changes are extensive but appear to be correct, consistent, and of high quality. I have not found any issues of high or critical severity.

Aasnaess

LGTM

cognite/client/_api/data_modeling/containers.py

dbrattli · 2025-11-07T07:44:40Z

cognite/client/_api/datapoints.py

                yield dps_lst[0] if is_single else dps_lst
            elif is_single:
-                yield from chunk_fn(dps_lst[0])  # type: ignore [misc]
+                for chunk in chunk_fn(dps_lst[0]):


Why not yield from?

Inside an async generator function

which is used by Cognite IDP

erlendvollset · 2025-11-12T12:31:43Z

MIGRATION_GUIDE.md

+- Extending a `Datapoints` instance is no longer supported.
+- **ClientConfig**:
+  - `max_workers` has now permanently moved to `global_config` after the deprecation period
+  - `timeout`: default has been increased from 30 sec to 60 sec


What's the rationale for this?

erlendvollset · 2025-11-12T12:34:29Z

cognite/client/_cognite_client.py

-    def get(self, url: str, params: dict[str, Any] | None = None, headers: dict[str, Any] | None = None) -> Response:
+    async def get(
+        self, url: str, params: dict[str, Any] | None = None, headers: dict[str, Any] | None = None
+    ) -> httpx.Response:


These should not return httpx objects, that's an abstraction leak that I'd like to get rid of. We should wrap them in our own Response object instead.

Same for the sync client

erlendvollset · 2025-11-12T12:35:53Z

cognite/client/config.py

        self.disable_ssl: bool = False
-        self.proxies: dict[str, str] | None = {}
+        self.proxy: str | httpx.Proxy | None = None


Same here, should not deal with httpx objects directly. Wrap it in our own instead.

erlendvollset · 2025-11-12T12:38:08Z

cognite/client/_api/time_series.py

            sort=prep_sort,
-        )
-
-    def __iter__(self) -> Iterator[TimeSeries]:


Why have the __iter__ methods been removed? - not mentioned in migration guide.

erlendvollset · 2025-11-12T12:39:17Z

.pre-commit-config.yaml


+      - id: sync-client-codegen
+        name: run sync codegen on changed files
+        entry: poetry run python scripts/sync_client_codegen/main.py run --files


This fails if the sync client is not up to date right?

haakonvt requested review from a team as code owners October 30, 2025 12:34

haakonvt force-pushed the v8-change-requests-to-httpx branch 7 times, most recently from 8f8308e to 66518da Compare November 5, 2025 11:53

gemini-code-assist bot reviewed Nov 5, 2025

View reviewed changes

Aasnaess previously approved these changes Nov 5, 2025

View reviewed changes

dbrattli reviewed Nov 6, 2025

View reviewed changes

cognite/client/_api/data_modeling/containers.py Show resolved Hide resolved

haakonvt changed the title ~~release 8.0.0a0 to PyPI~~ release 8.0.0a1 to PyPI Nov 6, 2025

haakonvt dismissed Aasnaess’s stale review via f05ee51 November 6, 2025 09:00

This comment was marked as outdated.

Sign in to view

dbrattli reviewed Nov 7, 2025

View reviewed changes

haakonvt force-pushed the v8-change-requests-to-httpx branch from f05ee51 to f0d63ae Compare November 9, 2025 11:13

erlendvollset added 11 commits November 9, 2025 12:33

Run mypy on tests_unit/test_config.py

b72c450

Run mypy on tests_unit/test_credential_providers.py

67ac963

Run mypy on tests_unit/test_docstring_examples.py

825018d

Run mypy on tests_unit/test_exceptions.py

3d5d235

Run mypy on tests_integration/test_api/test_workflows.py

da961bb

Run mypy on tests_integration/test_api/test_transformations

55fe18f

Run mypy on tests_integration/test_api/test_agents.py

a03370c

Run mypy on tests_integration/test_api/test_annotations.py

c3d79db

Make all tests return None

8a3d106

Run mypy on tests_integration/test_api/test_data_sets.py

f8feb6d

Run mypy on tests_integration/test_api/test_datapoint_subscriptions.py

3507f05

haakonvt added 24 commits November 9, 2025 12:33

update datapoints->dataframe tests after MultiIndex columns change

a50fb4d

improve robustness of workflow tests. change trigger to avoid spam

6a14da1

update transformations tests (some used to be async even bef v8)

4b304eb

do a mypy pass on tests

2201904

change scopes arg of OAuthClientCredentials to allow None

1a9462d

which is used by Cognite IDP

final mypy pass on sync APIs

5a05f23

use response header to evaluate is_auto_retryable (not .json())

8f8eae6

always keep time series identifier in dataframe columns

dc6da5d

perf: short circuit in util fn: at_least_one_is_not_none

e62f312

remove 'Cannot chain result sets...' check in instances/subscribe

76b28f4

remove no longer needed err handling of 'response.http_version'

c853d96

Add dunder str and repr-html to GlobalConfig

7557510

remove upper bound on pre-commit. run autoupdate

7f40b29

final mypy pass of fixes

927b9d0

final tests fixups

d7f38c1

final pass on sync APIs

6ce01de

bump version to 8.0.0a1

f82ec1b

update MIGRATION_GUIDE.md for v7 -> v8

471758a

fix generator return annot to union of iterators

bb7caaa

fix generator return annot to union of iterators in sync api

1d9f664

prepare codegen (sync api/client) for pre-commit/CI

25869f8

run code-gen on edited files in commit (in pre-commit)

3adb175

verify all codegen files in new CI check (.github/workflows/build.yml)

d0e2950

add section on 'Automatic Code Generation' to CONTRIBUTING.md

5c00175

haakonvt force-pushed the v8-change-requests-to-httpx branch from f0d63ae to c605eee Compare November 10, 2025 12:59

drop base_url default in ClientConfig. add cluster as opt

1ba5b84

haakonvt force-pushed the v8-change-requests-to-httpx branch from c605eee to 1ba5b84 Compare November 10, 2025 13:27

haakonvt changed the title ~~release 8.0.0a1 to PyPI~~ release 8.0.0a1 to PyPI (DM-3062) Nov 10, 2025

haakonvt mentioned this pull request Nov 12, 2025

refactor!: [V8] Split container classes into read/write versions (DM-3215) #2382

Closed

erlendvollset reviewed Nov 12, 2025

View reviewed changes

release 8.0.0a1 to PyPI (DM-3062) #2387

Are you sure you want to change the base?

release 8.0.0a1 to PyPI (DM-3062) #2387

Uh oh!

Conversation

haakonvt commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Note to reviewer:

Uh oh!

gemini-code-assist bot commented Oct 30, 2025

Uh oh!

amorken commented Nov 5, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Aasnaess left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This comment was marked as outdated.

dbrattli Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

haakonvt Nov 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

erlendvollset Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

erlendvollset Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

erlendvollset Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

erlendvollset Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

erlendvollset Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

erlendvollset Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

release `8.0.0a1` to PyPI (DM-3062) #2387

release `8.0.0a1` to PyPI (DM-3062) #2387

haakonvt commented Oct 30, 2025 •

edited

Loading

haakonvt Nov 7, 2025 •

edited

Loading