fix(sequences): accept list ids/external_ids in retrieve_last_row (#2266) #2352
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2266.
Summary
SequencesDataAPI.retrieve_last_rownow accepts:id: int | typing.Sequence[int] | Noneexternal_id: str | SequenceNotStr[str] | NoneBehavior:
SequenceRowsSequenceRowsListRationale
Docs and docstring say lists are supported, but the implementation only handled single values. This aligns code with docs and mirrors the list semantics used elsewhere.
Implementation notes
IdentifierSequence.load(...)/sequences/data/latestper identifier and aggregate usingexecute_tasks(...)Testing done
tests/tests_unit/test_api/test_sequences_data.pyexternal_id→ returnsSequenceRowsList, 2 HTTP callsid→ returnsSequenceRows, 1 HTTP callpoetry run pytest -q tests/tests_unit -k retrieve_last_rowpoetry run pre-commit run --all-files(ruff, ruff-format, mypy, custom checks, pydoclint) all passBackwards compatibility
Files changed
cognite/client/_api/sequences.pytests/tests_unit/test_api/test_sequences_data.pyChecklist