fix: update feature deadline #48
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhi-zorro
suggested changes
Sep 11, 2023
| @@ -93,19 +155,20 @@ private void add(String commandLine) { | |||
| } | |||
|
|
|||
| private void addProject(String name) { | |||
There was a problem hiding this comment.
create a POJO for project and use it here.
| } | ||
|
|
||
| private void addTask(String project, String description) { | ||
| public void addTask(String project, String description) { |
There was a problem hiding this comment.
don't use primitives in method parameters,make use of POJO.
| @@ -114,7 +177,7 @@ private void uncheck(String idString) { | |||
| setDone(idString, false); | |||
| } | |||
|
|
|||
| private void setDone(String idString, boolean done) { | |||
| public void setDone(String idString, boolean done) { | |||
There was a problem hiding this comment.
use POJO, eliminate primitive obsession.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paritosh