Skip to content

Conversation

jrnorth
Copy link
Contributor

@jrnorth jrnorth commented Sep 4, 2025

What does this PR do?

Upgrades to Karaf 4.4.8

Who is reviewing it?

@derekwilhelm
@brendan-hofmann

How should this be tested?

Generally use the system and verify it works as expected.

Checklist:

  • Documentation Updated
  • Update / Add Threat Dragon models
  • Update / Add Unit Tests
  • Update / Add Integration Tests

Notes on Review Process

Please see Notes on Review Process for further guidance on requirements for merging and abbreviated reviews.

Review Comment Legend:

  • ✏️ (Pencil) This comment is a nitpick or style suggestion, no action required for approval. This comment should provide a suggestion either as an in line code snippet or a gist.
  • ❓ (Question Mark) This comment is to gain a clearer understanding of design or code choices, clarification is required but action may not be necessary for approval.
  • ❗ (Exclamation Mark) This comment is critical and requires clarification or action before approval.

@jrnorth jrnorth requested a review from stustison as a code owner September 4, 2025 17:17
Copy link
Contributor

@brendan-hofmann brendan-hofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly just nitpicks. I'll also build this and do some manual testing.

@brendan-hofmann
Copy link
Contributor

I was able to install, ingest, and search.

These packages are also exported by the bouncycastle bundles installed by Karaf, which can cause import resolution problems for bundles that use them.
@ahoffer
Copy link

ahoffer commented Sep 8, 2025

build now

@cxddfbot
Copy link

cxddfbot commented Sep 8, 2025

Internal build has been started, your results will be available at build completion.

@cxddfbot
Copy link

cxddfbot commented Sep 8, 2025

Build SUCCESS See the job results in legacy Jenkins UI or in Blue Ocean UI.

@jrnorth
Copy link
Contributor Author

jrnorth commented Sep 11, 2025

build now

@cxddfbot
Copy link

Internal build has been started, your results will be available at build completion.

@cxddfbot
Copy link

Build SUCCESS See the job results in legacy Jenkins UI or in Blue Ocean UI.

@jrnorth
Copy link
Contributor Author

jrnorth commented Sep 11, 2025

build now

@cxddfbot
Copy link

Internal build has been started, your results will be available at build completion.

@cxddfbot
Copy link

Build SUCCESS See the job results in legacy Jenkins UI or in Blue Ocean UI.

@jrnorth jrnorth merged commit d61b099 into 2.29.x Sep 15, 2025
3 checks passed
@jrnorth jrnorth deleted the karaf-4.4.8 branch September 15, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants