Feat/rework zk proving eric #1256
Draft
+3,094
−918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- need to test with longer tests to ensure the parallelisation is truly happening - is the +10 hardhat port needed? - try with more integration tests # Conflicts: # tests/integration/hardhatprocess.nim # tests/integration/multinodes.nim # tests/integration/testcli.nim # tests/testIntegration.nim
# Conflicts: # tests/testIntegration.nim
# Conflicts: # tests/testIntegration.nim
# Conflicts: # tests/testIntegration.nim
# Conflicts: # tests/integration/hardhatprocess.nim
prevents showing error in the logs when an expected process exit code is encountered # Conflicts: # tests/integration/testcli.nim
# Conflicts: # tests/integration/testcli.nim
# Conflicts: # tests/ethertest.nim
- add a TestManager property to IntegrationTest, so manager does not need to be passed into all functions - cleanup: - remove unneeded stopHardhat function - add hardhat instance to manager outside of startHardhat
…error starting hardhat
allows user to know which tests are still running
Work around the AsyncProcess timeout not working correctly
# Conflicts: # tests/testIntegration.nim
# Conflicts: # tests/integration/hardhatprocess.nim
…rt, and enhance prover functionality
… SomeTree and SomeHash
…and streamline async procedures
… circomCompat backends
…h testproverfactory
…test setup for CLI
To hopefully prevent the http client from crashing in CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR to see if this works in CI