Skip to content

Conversation

danilowoz
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Apr 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sandpack-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 10, 2023 0:09am

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 7, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 58fc409:

Sandbox Source
Sandpack Configuration
sandpack-run-stale-value Configuration

Copy link
Member

@DeMoorJasper DeMoorJasper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good

) {
args.push(item.value);
const nodeboxCommand: Command = [command, args, { env }];
listOfCommands.push(nodeboxCommand);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit weird, to have a hardcoded dependency on AND in your data structure. But probably fine for testing

Base automatically changed from draft/inspiring-danny to main April 11, 2023 12:14
@danilowoz danilowoz marked this pull request as draft April 11, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants