-
Notifications
You must be signed in to change notification settings - Fork 32
Add logging on all RESTful and WebSocket requests in VS Code #580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
EhabY
wants to merge
7
commits into
coder:main
Choose a base branch
from
EhabY:add-logging-on-all-requests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eb8a0a3
to
2f0593d
Compare
EhabY
commented
Sep 9, 2025
437e0ff
to
2f3db57
Compare
2285279
to
e32ba50
Compare
code-asher
reviewed
Sep 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not had a chance to run it yet (hopefully tomorrow) but gave it a first pass and it is looking fantastic!
e64e992
to
e97e687
Compare
EhabY
commented
Sep 11, 2025
d33d380
to
6739540
Compare
Feel free to re-request a review whenever you are ready for a new one! |
c1cf229
to
5ae5b5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #532
This PR introduces several enhancements to improve logging and consistency:
Axios Logging Interceptor
Added a logging interceptor to the Axios instance during its creation. Each request is tagged with a unique UUID, allowing us to correlate it with its corresponding response and measure the total in-flight time. To avoid excessive noise, response bodies are deliberately excluded from the logs as they were too verbose and difficult to read.
Unified WebSocket Creation
Consolidated WebSocket creation logic by standardizing on a
OneWayWebSocket
. For VS Code, this uses thews
Node library. Previously, there were two separate places creating their own WebSocket connections and another two relying on SSE. These SSE implementations were converted to one-way WebSockets for improved consistency and performance. Additional logging was also added to track WebSocket creation, errors, and closure events.For now, the logging level is set to
trace
for non-error logs anderror
for errors. This can easily be adjusted later. I have also isolated the logging logic inlogging
so it's all in one place. Let me know if we want to add more details or possibly remove some.