Fix symbolic links not being overwritten during archive extraction #403
+178
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When extracting an archive, existing symbolic links in the destination directory are not overwritten even when the archive contains a symlink with a different target.
Changes
FileUtils.resolveFile()withnew File()inAbstractUnArchiver.extractFile()- the former follows symlinks, causing extraction to target the wrong fileshouldExtractEntry()- return true immediately for symlinks to enable overwritingTesting
Added
testSymlinkOverwriteZip()andtestSymlinkOverwriteTar()to verify symlinks are properly overwritten across archive formats.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.