[WIP] Consumer app and utils #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spompea-cfa
temporarily deployed
to
development
GitHub Actions
Inactive
spompea-cfa
temporarily deployed
to
development
GitHub Actions
Inactive
jamesiarmes
requested changes
Sep 10, 2025
There was a problem hiding this comment.
Since this is the first time we're adding python, I'd like to see it added to our CodeQL workflow.
Additionally, can we add some python specific static analyisis/scanning added to the branch and main workflows? This could be a follow-up, but I'd like to see it in place before we start adding too much Python to the repo.
Overall, this looks great! I left a few minor comments, and I'd like to some some unit tests at some point, but not a blocker for this.
jamesiarmes
approved these changes
Sep 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Jira ticket.