-
Notifications
You must be signed in to change notification settings - Fork 0
feat: Added auto-scaling functionality to the consumer and redoer. #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Plan output for service config
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds auto-scaling functionality to the consumer and redoer services by implementing AWS Application Auto Scaling with CloudWatch alarms based on SQS queue metrics. The scaling system monitors queue depth to scale up containers when messages are present and scale down when the queue remains empty for a configurable threshold.
- Added auto-scaling configuration variables for maximum containers, message thresholds, and empty queue timing
- Implemented AWS Application Auto Scaling policies with step scaling for both consumer and redoer services
- Created CloudWatch alarms to trigger scaling actions based on SQS queue message count
Reviewed Changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
tofu/modules/system/variables.tf | Added auto-scaling configuration variables |
tofu/modules/system/ecs.tf | Updated service modules to use cluster name and added scaling policies |
tofu/modules/system/alarms.tf | Created CloudWatch alarms for queue monitoring and scaling triggers |
tofu/modules/persistent_service/ | Added auto-scaling functionality with step scaling policies and scaling targets |
tofu/config/service/ | Propagated new variables to service configuration |
.github/workflows/ | Added new environment variables to CI/CD workflows |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Also removed
SENZING_DATASOURCES
from the tools container since the consumer can create data sources at runtime now.