Skip to content

Conversation

spompea-cfa
Copy link
Contributor

@spompea-cfa spompea-cfa commented Oct 7, 2025

Add integration tests plus README instructions on how to run them.

Additional ancillary updates:

  • Update README to enumerate all environment variables used by middleware.
  • Exporter puts the output file in a specific (configurable) folder and uses a chronologically sortable naming format: 2025-10-07T23:15:54-UTC-exporter-output.json (the tag, e.g., exporter-output, is also configurable).
  • Other tidying.

@spompea-cfa spompea-cfa changed the title [WIP] Add testing Add testing Oct 8, 2025
@spompea-cfa spompea-cfa marked this pull request as ready for review October 8, 2025 20:49
@spompea-cfa spompea-cfa requested a review from a team as a code owner October 8, 2025 20:49
@jamesiarmes jamesiarmes requested a review from Copilot October 9, 2025 15:54
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds comprehensive testing infrastructure and documentation, along with several improvements to the middleware system. The changes include a full integration test that validates the entire data flow from SQS ingestion through Senzing processing to S3 export, plus configuration enhancements and documentation updates.

Key changes:

  • Integration test framework using unittest with LocalStack services
  • Enhanced exporter with configurable output folder and chronologically sortable filename format
  • Comprehensive README updates with environment variable documentation and testing instructions

Reviewed Changes

Copilot reviewed 8 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
test/test_flow.py Full integration test validating SQS → Consumer → Redoer → Exporter → S3 flow
test/fixtures/flow-output.json Expected JSON output for test validation
test/fixtures/customers.jsonl Test data containing 120 customer records
middleware/exporter.py Enhanced with configurable folder and timestamp-based filenames
middleware/redoer.py Added documentation comments explaining retry logic
docker-compose.yaml Improved service dependencies and environment variable organization
dev-scripts/s3_get.py Fixed file path handling for S3 folder structure
README.md Comprehensive documentation of environment variables and testing procedures

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Member

@jamesiarmes jamesiarmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a GitHub actions workflow to run this automatically on push?

@spompea-cfa spompea-cfa changed the title Add testing Add integration tests Oct 9, 2025
@spompea-cfa
Copy link
Contributor Author

Can you add a GitHub actions workflow to run this automatically on push?

good idea. will open a separate PR.

@jamesiarmes jamesiarmes merged commit 275f244 into main Oct 9, 2025
9 checks passed
@jamesiarmes jamesiarmes deleted the add-testing branch October 9, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants