fix: add nested transaction support #267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
run_transaction utilizes the special 'cockroach_restart' protocol, as per: https://www.cockroachlabs.com/blog/nested-transactions-in-cockroachdb-20-1/ In order to support nested transactions, the cockroach_restart protocol for nested transactions can be related on versions after v20.1. The motivation for this change was to allow multiple nested transactions to occur over the same engine connection and high level transaction (BEGIN/COMMIT). This allows one nested transaction to perform an INSERT or UPDATE, while subsequent transactions could retrieve that result (before the final COMMIT). This primarily works around conditions in sqlalchemy, where one would like to perform an orm.flush(), but cannot, when utilizing the cockroach run_transaction model. By default the run_transaction defaults to using the cockroach_restart protocol, so no observed behavior is seen to current users. Signed-off-by: Mike Marchetti <[email protected]>
|
thanks for the fixes @gordthompson |
Closed
rafiss
approved these changes
Jun 10, 2025
|
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
run_transaction utilizes the special 'cockroach_restart' protocol, as per: https://www.cockroachlabs.com/blog/nested-transactions-in-cockroachdb-20-1/
In order to support nested transactions, the cockroach_restart protocol for nested transactions can be related on versions after v20.1.
The motivation for this change was to allow multiple nested transactions to occur over the same engine connection and high level transaction (BEGIN/COMMIT). This allows one nested transaction to perform an INSERT or UPDATE, while subsequent transactions could retrieve that result (before the final COMMIT). This primarily works around conditions in sqlalchemy, where one would like to perform an orm.flush(), but cannot, when utilizing the cockroach run_transaction model.
By default the run_transaction defaults to using the cockroach_restart protocol, so no observed behavior is seen to current users.