Skip to content

Conversation

spilchen
Copy link
Contributor

@spilchen spilchen commented Aug 29, 2025

The rate limit is "per node per table" not "per leaseholder per table". Updating to reflect the server code.

Fixes DOC-14746

@spilchen spilchen self-assigned this Aug 29, 2025
Copy link

netlify bot commented Aug 29, 2025

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit afeb860
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-interactivetutorials-docs/deploys/68b707eba344d800083e6265

Copy link

netlify bot commented Aug 29, 2025

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit afeb860
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-api-docs/deploys/68b707ebc16da00008d2b300

Copy link

netlify bot commented Aug 29, 2025

Netlify Preview

Built without sensitive environment variables

Name Link
🔨 Latest commit afeb860
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-docs/deploys/68b707ebd8e4b30008a82b6b
😎 Deploy Preview https://deploy-preview-20235--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@spilchen
Copy link
Contributor Author

@spilchen spilchen requested review from rmloveland and rafiss August 29, 2025 17:00
@spilchen spilchen marked this pull request as ready for review August 29, 2025 17:00
@rafiss
Copy link
Contributor

rafiss commented Aug 29, 2025

Let's ask @rmloveland for a review as well.

Copy link
Contributor

@rmloveland rmloveland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thank you!

@rafiss rafiss enabled auto-merge (rebase) September 2, 2025 15:05
The rate limit is "per node per table" not "per leaseholder per table".
Updating to reflect the server code.
@rafiss rafiss force-pushed the gh-144463/250829/1138/ttl-rate-limit/pr-ready branch from 755d9dc to afeb860 Compare September 2, 2025 15:06
@rafiss rafiss merged commit c8b31b6 into cockroachdb:main Sep 2, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants