Skip to content

Conversation

ebembi-crdb
Copy link
Contributor

@ebembi-crdb ebembi-crdb commented Aug 29, 2025

  • Add new archived documentation page at
    /releases/archived-documentation.html
  • Include v19.2 as the only available archived version with working
    ZIP download link
  • Add "NEW" tag and navigation entry for the archived documentation
    page
  • Style improvements for sidebar tags and archived documentation
    interface

Jira link - https://cockroachlabs.atlassian.net/browse/EDUENG-54

@ebembi-crdb ebembi-crdb requested a review from a team as a code owner August 29, 2025 10:01
Copy link

netlify bot commented Aug 29, 2025

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit 84fd7f7
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-api-docs/deploys/68b749f3d17492000897a00a

Copy link

netlify bot commented Aug 29, 2025

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit 84fd7f7
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-interactivetutorials-docs/deploys/68b749f36acb390008588ff8

Copy link

netlify bot commented Aug 29, 2025

Netlify Preview

Name Link
🔨 Latest commit 84fd7f7
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-docs/deploys/68b749f3bb48fd00088b7715
😎 Deploy Preview https://deploy-preview-20229--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@ebembi-crdb ebembi-crdb changed the title first commit Add archived documentation page with v19.2 support Aug 29, 2025
Copy link

github-actions bot commented Aug 29, 2025

Files changed:

@rmloveland
Copy link
Contributor

@ebembi-crdb can you pls link a Jira issue in the description of this PR? it would be good to see the requirements for this task while reviewing and giving feedback

@rmloveland
Copy link
Contributor

when i click on the link to the ZIP file in https://deploy-preview-20229--cockroachdb-docs.netlify.app/docs/releases/archived-documentation.html it shows access denied to the cloud storage with the file

Screenshot 2025-08-29 at 11 16 08 AM

Copy link
Contributor

@rmloveland rmloveland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looking good, had some specific feedback we should address to bring in line with our other docs

Copy link
Contributor

@rmloveland rmloveland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getting closer, needs updates to the text in a couple of places and removal of "NEW" tag in sidebar (see comments)

@rmloveland reviewed 1 of 6 files at r1, 2 of 3 files at r2, 3 of 3 files at r3, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @ebembi-crdb)

.download-link:hover { text-decoration:underline; }
</style>

Access documentation for previous versions of CockroachDB that are no longer actively maintained.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update this to say "This page contains downloads of archived documentation for CockroachDB versions that are no longer supported"

Access documentation for previous versions of CockroachDB that are no longer actively maintained.

{{ site.data.alerts.callout_info }}
CockroachDB recommends using the most recent version for the best experience and most up-to-date documentation. Archived documentation is provided **as-is** and is no longer actively maintained.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update this to use the text i wrote in my previous comment

<button type="button" class="button-primary">View Documentation</button>
</div>

## All Archived Versions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update the header and text as described in my previous comment

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@rmloveland rmloveland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @ebembi-crdb !!

@ebembi-crdb ebembi-crdb merged commit bd4e234 into main Sep 3, 2025
5 checks passed
@ebembi-crdb ebembi-crdb deleted the feat/archival-page branch September 3, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants