-
Notifications
You must be signed in to change notification settings - Fork 474
Add archived documentation page with v19.2 support #20229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify project configuration. |
Files changed:
|
@ebembi-crdb can you pls link a Jira issue in the description of this PR? it would be good to see the requirements for this task while reviewing and giving feedback |
when i click on the link to the ZIP file in https://deploy-preview-20229--cockroachdb-docs.netlify.app/docs/releases/archived-documentation.html it shows access denied to the cloud storage with the file ![]() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall looking good, had some specific feedback we should address to bring in line with our other docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getting closer, needs updates to the text in a couple of places and removal of "NEW" tag in sidebar (see comments)
@rmloveland reviewed 1 of 6 files at r1, 2 of 3 files at r2, 3 of 3 files at r3, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @ebembi-crdb)
.download-link:hover { text-decoration:underline; } | ||
</style> | ||
|
||
Access documentation for previous versions of CockroachDB that are no longer actively maintained. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please update this to say "This page contains downloads of archived documentation for CockroachDB versions that are no longer supported"
Access documentation for previous versions of CockroachDB that are no longer actively maintained. | ||
|
||
{{ site.data.alerts.callout_info }} | ||
CockroachDB recommends using the most recent version for the best experience and most up-to-date documentation. Archived documentation is provided **as-is** and is no longer actively maintained. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update this to use the text i wrote in my previous comment
<button type="button" class="button-primary">View Documentation</button> | ||
</div> | ||
|
||
## All Archived Versions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please update the header and text as described in my previous comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @ebembi-crdb !!
/releases/archived-documentation.html
ZIP download link
page
interface
Jira link - https://cockroachlabs.atlassian.net/browse/EDUENG-54