docs: remove v19.2 references from Jekyll data files #20069
+164
−71,044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ebembi-crdb
commented
Aug 5, 2025
ebembi-crdb
commented
- Remove v19.2 entries from _data/redirects.yml version arrays
- Replace v19.2 release blocks in _data/releases.yml with single lines
- Cleanup to remove archived version from documentation site
- Remove v19.2 entries from _data/redirects.yml version arrays - Replace v19.2 release blocks in _data/releases.yml with single lines - Cleanup to remove archived version from documentation site
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
❌ Deploy Preview for cockroachdb-docs failed. Why did it fail? →
|
rmloveland
requested changes
Aug 5, 2025
There was a problem hiding this comment.
@ebembi-crdb from the build log it looks like you need to fix two broken links pointing to stuff in 19.2 that will no longer exist
otherwise we're on the right track! thanks for working on this!
once the build is green please re-request review and i'll look again ASAP!
1:59:57 AM: htmltest started at 05:59:57 on _site
1:59:57 AM: ========================================================================
1:59:58 AM: running in concurrent mode, this is experimental
2:00:08 AM: docs/releases/v19.2.html
2:00:08 AM: hash does not exist --- docs/releases/v19.2.html --> #v19-2-0
2:00:08 AM: docs/releases/cloud.html
2:00:08 AM: hash does not exist --- docs/releases/cloud.html --> /docs/releases/v19.2.html#v19-2-4
2:00:09 AM: ========================================================================
2:00:09 AM: ✘✘✘ failed in 11.877152545s
rmloveland
approved these changes
Aug 6, 2025
|
PS a lot of your changes were necessary because we still need https://cockroachlabs.atlassian.net/browse/DOC-14152 If we can do some kind of linting / validation on image versions that would be a nice feature (i'll also drop a comment there) |
rmloveland
requested changes
Aug 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.