-
Notifications
You must be signed in to change notification settings - Fork 0
Expose cpu arch, number of cpus, and total memory #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+1,629
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
71ab1c2
to
20bac93
Compare
7125ba5
to
cd8df3d
Compare
notandy
requested changes
Aug 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works for me, although the memory looks a bit odd:
Capabilities:
Cpu Arch: x86_64
Cpus: 256
Memory: 4227289164Ki
Which is probably ok I assume.
4227289164Ki should be about right with 4 numa cells with 1056822291 KiB each. |
f5d0945
to
9a4b272
Compare
notandy
approved these changes
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a capabilities client that automatically connects to libvirt and fetches capabilities of the hypervisors. The capabilities are mapped to a new
v1alpha.CapabilitiesStatus
struct, which is part ofv1alpha.HypervisorStatus
. As a starter, we export the cpu architecture, as well as the total number of cpus and memory over all numa cells.I've also taken the freedom and removed the
goconst
linter. It produced two obvious false positives :)