Skip to content

Add support for Alibaba Cloud ApsaraDB Confidential Database #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add support for Alibaba Cloud ApsaraDB Confidential Database #477

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da535e5
Add support for Alibaba Cloud ApsaraDB Confidential Database
tyler-lee Mar 7, 2024
d5e4907
Merge branch 'main' into main
bpkroth Mar 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,11 @@
<version>8.0.30</version>
<scope>runtime</scope>
</dependency>
<dependency>
<groupId>com.aliyun</groupId>
<artifactId>aliyun-encdb-mysql-jdbc</artifactId>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this dependency isn't required by standard MySQL instances, I think it should go in its own profile. Something like this (pseudocode, please fill in and test the details):

<profile>
  <id>aliyundb</id> <!-- FIXME: Is this the best name to use here? -->
  ...
  <!-- copies of most of the rest of the MySQL profile dependencies -->
  <!-- additional aliyun db dependencies -->
                  <dependency>
                    <groupId>com.aliyun</groupId>
                    <artifactId>aliyun-encdb-mysql-jdbc</artifactId>
                  </dependency>
...
</profile>

<version>1.0.8</version>
</dependency>
</dependencies>
</profile>
<!-- Oracle DB driver needed in profile compilation -->
Expand Down Expand Up @@ -519,6 +524,7 @@
-->
<ignoredUnusedDeclaredDependency>org.postgresql:postgresql:jar</ignoredUnusedDeclaredDependency>
<ignoredUnusedDeclaredDependency>mysql:mysql-connector-java:jar</ignoredUnusedDeclaredDependency>
<ignoredUnusedDeclaredDependency>com.aliyun:aliyun-encdb-mysql-jdbc:jar</ignoredUnusedDeclaredDependency>
<ignoredUnusedDeclaredDependency>com.oracle.database.jdbc:ojdbc11:jar</ignoredUnusedDeclaredDependency>
<ignoredUnusedDeclaredDependency>org.mariadb.jdbc:mariadb-java-client:jar</ignoredUnusedDeclaredDependency>
<ignoredUnusedDeclaredDependency>com.google.cloud:google-cloud-spanner-jdbc:jar</ignoredUnusedDeclaredDependency>
Expand Down