Add tests #64
Open
Add tests #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please do. I am using shared-runners. |
|
Added a preliminary test workflow. I adopted the one from |
|
@mahendrapaipuri better late than never they say. Could you rebase this on main? |
|
@cmd-ntrf I am so sorry, I missed your comment. I will try to do it over this weekend! |
Set correct EMPTY_LIST_STR for each module system Fix print_output_decorator by making it async Improve module list logic by properly catching hidden modules Remove header in savelist if present
This is very rudimentary. Most probably there will be failed tests.
This is needed for coverage to generate cov report properly
mahendrapaipuri
force-pushed
the
add_tests
branch
from
52f9839 to
ee44715
Compare
* ci: Bump actions versions and remove unnecessary test cases * build: Remove support for Python 3.6-3.8 and add support till 3.13 * fix: Correct module_system function name in module Signed-off-by: Mahendra Paipuri <[email protected]>
* Seems unnecessary Signed-off-by: Mahendra Paipuri <[email protected]>
Signed-off-by: Mahendra Paipuri <[email protected]>
Signed-off-by: Mahendra Paipuri <[email protected]>
|
@cmd-ntrf There you go, rebased and fixed minor issues mostly in CI. Let me know if your feedback!! |
There was a problem hiding this comment.
Pull Request Overview
This PR introduces basic tests for the package and updates some workflows and module functionality.
- Adds tests for both the module API and HTTP handlers.
- Updates configuration files (pytest.ini, pyproject.toml) and GitHub workflows.
- Makes minor improvements in module functions, such as refining error messages and cache handling.
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_module.py | Adds tests for module commands and tests for various module APIs. |
| tests/test_handlers.py | Adds tests for HTTP endpoints of the module handlers. |
| tests/pytest.ini | Configures pytest options including coverage and HTML reports. |
| tests/conftest.py | Provides common fixtures for tests across module and handlers. |
| pyproject.toml | Updates project configuration including Python version and build options. |
| module/init.py | Updates module API functions and error messages. |
| jupyterlmod/handler.py | Adds new logoHandler functionality and refactors imports. |
| jupyterlmod/init.py | Updates server extension handler registration. |
| .github/workflows/test.yml | Adds a CI workflow job to run tests and verify extensions. |
| .github/workflows/main.yml | Updates workflows to use newer action versions. |
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds basic tests for the package. Currently, we implemented the tests for
modulepackage and we are also testinghandlers.All fixtures are defined in
conftest.pyand we are reusing them in tests formoduleandhandlers.@cmd-ntrf Can I add a workflow to test these tests in CI? I did not add it now as I am not sure if you are using shared runners (with quota) or your on-premise runners.