Skip to content

Conversation

dongowu
Copy link

@dongowu dongowu commented Sep 26, 2025

Motivation

Solution

  1. Load Balancer Example
    • Demonstrates all 6 load balancing strategies:
      • Round Robin
      • Weighted Round Robin
      • P2C
      • Weighted Random
      • Least Connection
      • Response Time Weighted
    • Shows proper error handling and configuration
      
  2. Testing Coverage
    • Unit tests for empty instance lists
    • Single instance scenarios
    • Multiple instance distribution
    • Weight-based selection verification
      

@dongowu dongowu requested review from a team as code owners September 26, 2025 08:17
Copy link
Member

@PureWhiteWu PureWhiteWu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks very much for your contribution!

These loadbalance algorithms are not verified in production by our team, and we are not so familiar with those algorithms, so we cannot guarantee performance and availability. So I think it's not suitable to merge this into Volo at this time.

But I think it's better to be maintained as a Volo ecological project under https://github.com/volo-rs.

If you are willing to maintain this under volo-rs, I can create a repo for you there.

What do you think?

Thanks again for your great contribution!

@dongowu dongowu force-pushed the devloadblance branch 2 times, most recently from e011ecf to 0ab411f Compare September 26, 2025 10:40
@dongowu
Copy link
Author

dongowu commented Sep 26, 2025

您好,非常感谢您的贡献!

这些负载均衡算法尚未经过我们团队在生产环境中的验证,而且我们对这些算法也不太熟悉,因此无法保证其性能和可用性。因此,我认为目前还不适合将其合并到 Volo 中。

但我觉得还是作为Volo生态项目在https://github.com/volo-rs下维护比较好。

如果您愿意维护这个volo-rs,我可以在那里为您创建一个 repo。

你怎么认为?

再次感谢您的巨大贡献!

ok

@PureWhiteWu
Copy link
Member

你好,我已经为你在 Volo-rs 下建好了仓库,并邀请你了 https://github.com/volo-rs/volo-loadbalance/invitations

@dongowu
Copy link
Author

dongowu commented Sep 26, 2025

ok 我整理下代码

@dongowu dongowu marked this pull request as draft September 26, 2025 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants