feat(adk): add Config for Planner/Executor/Replanner GenInputFn #454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| // NewPlan is a function type that creates a new Plan instance. | ||
| type NewPlan func(ctx context.Context) Plan | ||
| // PlanFactory is a function type that creates a new Plan instance. | ||
| type PlanFactory func(ctx context.Context) Plan |
There was a problem hiding this comment.
🚨 Breaking API Changes Detected
Package: github.com/cloudwego/eino/adk/prebuilt/planexecute
Incompatible changes:
- ExecutionContext: removed
- GenModelInputFn: removed
- GenPlannerModelInputFn: changed from func(context.Context, []*github.com/cloudwego/eino/schema.Message) ([]*github.com/cloudwego/eino/schema.Message, error) to func(context.Context, []*github.com/cloudwego/eino/schema.Message, *PlannerConfig) ([]*github.com/cloudwego/eino/schema.Message, error)
- NewPlan: removed
- PlannerConfig.NewPlan: removed
- ReplannerConfig.GenInputFn: changed from GenModelInputFn to GenReplannerModelInputFn
- ReplannerConfig.NewPlan: removed
Review Guidelines
Please ensure that:
- The changes are absolutely necessary
- They are properly documented
- Migration guides are provided if needed
📊 Coverage Report: |
|
|
||
| // GenPlannerModelInputFn is a function type that generates input messages for the planner. | ||
| type GenPlannerModelInputFn func(ctx context.Context, userInput []adk.Message) ([]adk.Message, error) | ||
| type GenPlannerModelInputFn func(ctx context.Context, userInput []adk.Message, cfg *PlannerConfig) ([]adk.Message, error) |
There was a problem hiding this comment.
这个为啥入参是 planner config 啊
meguminnnnnnnnn
approved these changes
Sep 15, 2025
feat: change NewPlan to PlanFactory feat: adjust comments
hi-pender
force-pushed
the
feat/adjust_api
branch
from
5cddb4d to
16cb97c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Check the PR title.
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
zh(optional):
(Optional) Which issue(s) this PR fixes:
(optional) The PR that updates user documentation: