chore: Remove unused catch variables #170
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This started as an attempted follow-up for #169 to take advantage of new optimizations available in ES2019. Unfortunately, I couldn't many in this codebase. There are a couple of modernization tweaks in this branch (changing
.indexOf(...) > -1to.includes(...)and replacing.applywith a spread), but the main change I wound up making was just getting rid of unusedcatchvariables:That shaves off a few bytes from the bundle, and it's also a code style improvement IMO, as it makes it clearer that the caught exception is unused. I've configured the no-unused-vars rule to catch that pattern in the future.
If this is approved, I'll submit the same change for cloudscape-design/components, where I expect the bundle size improvement to be more significant.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.