chore(heureka): proposes ideal UI queries for existing features #910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: dbc119a The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
hodanoori
force-pushed
the
hoda-heureka-ui-queries
branch
from
ad23b0c to
354b5d0
Compare
|
barsukov
changed the title
barsukov
changed the title
ArtieReus
reviewed
Apr 23, 2025
There was a problem hiding this comment.
thx @hodanoori for the documentation!. I suggest moving the "ideal queries" to a documentation folder within Heureka, as they are not currently being used and might cause confusion.
Since this is purely documentation, there's no need for a changeset.
…da-heureka-ui-queries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces ideal GraphQL queries for existing UI features. Each query is designed to include only the data needed for the relevant views, which improves readability and reduces complexity in the UI code. As a result, we can eliminate the need for data normalization (currently handled in
utils) and avoid defining custom types. These are simplified versions of the existing, more complex queries found in the same folder (graphql/Services) and can serve as a foundation for review and optimization.Note:
getServicesIssuesCountsandgetServiceFiltersare already aligned with the UI, so no changes are needed for them.Changes Made
Related Issues
Screenshots (if applicable)
Testing Instructions
npm inpm run TASKChecklist
PR Manifesto
Review the PR Manifesto for best practises.