Review of initial codespaces setup

01_hello-docker/README.md

@@ -32,6 +32,8 @@ apt update && apt install -y nginx
 
 Now you should see the welcome page of nginx.
 
+> TODO how to open the browser?
+
 ## Exit the container
 
 ```bash

03_container-lifecycle/README.md

@@ -30,6 +30,8 @@ docker run -it --name my-busybox busybox:1.32.0 sh -c "while true; do $(echo dat
 
 * To detach from the container, press Ctrl+p followed by Ctrl+q. Verify the status of the container.
 
+> TODO does not work on my mac, I am not sure if we can fix this
+
 ```bash
 docker ps -a
 ```
@@ -42,6 +44,8 @@ docker ps -a
 docker attach my-busybox
 ```
 
+> TODO docker cli completion seems not to be enabled 
+
 * To stop it, press Ctrl+c. Verify the status of the container.
 
 ```bash
@@ -78,6 +82,8 @@ docker run -it -d --name my-busybox busybox:1.32.0 sh -c "while true; do $(echo
 docker attach my-busybox
 ```
 
+> TODO missing how to exit from container
+
 * Cleanup
 
 ```bash

08_build-ignore/README.md

@@ -37,6 +37,8 @@ passwords.txt
 some-large-image.jpg
 ```
 
+> TODO missing .soloution files
+
 * Build the image
 
 ```bash

09_entrypoint-vs-cmd/README.md

@@ -33,6 +33,8 @@ ENTRYPOINT [ "echo" ]
 CMD [ "hello docker" ]
 ```
 
+> TODO missing .soloution files
+
 * Build and run the image
 
 ```bash
@@ -55,3 +57,5 @@ docker run -it --rm --name entrypoint-vs-cmd entrypoint-vs-cmd:2.0.0 bonjour doc
 ```bash
 docker run -it --rm --name entrypoint-vs-cmd --entrypoint sleep entrypoint-vs-cmd:2.0.0 5
 ```
+
+> TODO missing exit command 

10_shell-vs-exec-form-variable-substitution/README.md

@@ -36,6 +36,8 @@ docker run -it shell-vs-exec-form-vars:1.0.0
 ENTRYPOINT /bin/echo $FOO
 ```
 
+> TODO missing .soloution files
+
 > This is shell form of `ENTRYPOINT`
 
 ## Rebuild the image

11_shell-vs-exec-form-PID1/README.md

@@ -36,6 +36,8 @@ docker run -it shell-vs-exec-form-pid1:1.0.0
 ENTRYPOINT ps aux
 ```
 
+> TODO missing .soloution files
+
 > This is shell form of `ENTRYPOINT`
 
 ## Rebuild the image

12_multistaged-builds/README.md

@@ -44,6 +44,8 @@ COPY --from=builder /build/main .
 ENTRYPOINT [ "./main" ]
 ```
 
+> TODO missing .soloution files
+
 ## Rebuild and run the application
 
 ```bash

13_caching/README.md

@@ -70,6 +70,8 @@ ENTRYPOINT [ "npm" ]
 CMD [ "start" ]
 ```
 
+> TODO missing .soloution files
+
 * Do the initial build
 
 ```bash

14_linting/README.md

@@ -39,3 +39,5 @@ Dockerfile:7 DL3025 warning: Use arguments JSON notation for CMD and ENTRYPOINT
 ```
 
 Fix all warning messages and try to fix some info messages in the Dockerfile and run hadolint for verification of your work.
+
+> TODO missing .soloution files

15_logs/README.md

@@ -38,6 +38,8 @@ You can costumize the log-driver in the file `/etc/docker/daemon.json` via these
 
 >This sets the log-driver to `json-file` which is the default. Furthermore, you can define log file rotation by setting the log-opts properties `max-size` and `max-file` .
 
+> TODO not sure if that works... the logs did not show any diff. probably the docker service has to be restarted on the host afterwards
+
 ## Run a container with a specific log-driver
 
 > First, make sure syslog-ng is running:

18_docker-compose/README.md

@@ -58,6 +58,8 @@ curl localhost:8080/metrics
 
 >You can get the external IP via the command `make get-external-ip` in your home directory.
 
+> TODO missing make file - is this still needed at all?
+
 ## Create a Datasource
 
 Create a Datasource of type `Prometheus` and the URL `http://prometheus:9090`