feat: Handle pollForProcessingImage breaking change

[RS-labhub]

Description

Updates CldImage to handle the breaking change in @cloudinary-util/util where pollForProcessingImage now returns a PollForProcessingImageResponse object instead of a boolean.

Issue Ticket Number

Fixes #51

Type of change

• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

• I have followed the contributing guidelines of this project as mentioned in CONTRIBUTING.md
• I have created an issue ticket for this PR
• I have checked to ensure there aren't other open Pull Requests for the same update/change?
• I have performed a self-review of my own code
• I have run tests locally to ensure they all pass
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes needed to the documentation

[vercel]

@RS-labhub is attempting to deploy a commit to the Cloudinary DevX Team on Vercel.

A member of the Team first needs to authorize it.

[RS-labhub]

@devpatocld you can check it now.

referring: #51 (comment)

[RS-labhub]

Bumping this up @devpatocld @eeeps

[RS-labhub]

It's been more than a month. Still no action is taken.

@devpatocld @eeeps

Edit: I just saw this comment. I'm glad I didn't participate in Hacktoberfest this year. LOL

[eportis-cloudinary]

@RS-labhub I think the issue you claimed to fix, of the pollForProcessingImage result being object was actually already handled correctly, by https://github.com/cloudinary-community/astro-cloudinary/pull/63/files

The issue still being open, and us adding the hacktoberfest tags to it, was our fault, and I apologize if we wasted a moment of your time.

As for the PR - it seems you have found an unrelated (but close in the source code) issue, which is a mistake in handling query parameters incorrectly. Reading the code, it seems like an obvious fix, however I'm frankly unable to replicate the issues I would think it would cause, and am unsure how this bit of code interacts with the automatic responsive image features and srcset.

As you found in the other issue, we have been very slow to review PRs this year, and I sincerely apologize for the delay. I will pick this back up in early December, and my colleague @devpatocld will reach out to you about Hacktoberfest swag. In the meantime, if you have an example case where us tacking the key onto the URL with & instead of ? actually causes an issue, I would love to see it!

[RS-labhub]

Hey @eportis-cloudinary, thank you for your kind gesture.

Yes, I saw the source code, and the issue has already been solved but there was just incorrect or missing parameter logic handling there so I fixed it.

And for your question:

In the meantime, if you have an example case where us tacking the key onto the URL with & instead of ? actually causes an issue, I would love to see it!

The answer is, it doesn't cause issue but there might be an edge case if the url uses both ?& like https://res.cloudinary.com/.../image.jpg?&key=123.

The current implementation handles both cases properly:

• No query string → use ?
• Has query string → use &

And ig this is the standard way to append query parameters to URLs.