Skip to content

Add deterministic XXH64 hashing specs #4460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add deterministic XXH64 hashing specs #4460

wants to merge 1 commit into from

Conversation

philippthun
Copy link
Member

@philippthun philippthun commented Jul 21, 2025 •
edited
Loading

  • test UserResetInterval offset calculation using Digest::XXH64
  • add unit tests for StagingActionBuilder#buildpack_path hashing behavior
  • ensure deterministic examples for Digest::XXH64 to catch formatting issues

Fixes #3698

  • I have reviewed the contributing guide

  • I have viewed, signed, and submitted the Contributor License Agreement

  • I have made this pull request to the main branch

  • I have run all the unit tests using bundle exec rake

  • I have run CF Acceptance Tests

@philippthun philippthun marked this pull request as draft July 21, 2025 11:48
@philippthun philippthun force-pushed the codex/add-unit-tests-for-issue-3698 branch from 73737dc to de2bb1f Compare July 24, 2025 12:05
@philippthun philippthun changed the title Add tests for Digest::XXH64 usages Add deterministic XXH64 hashing specs Jul 24, 2025
@philippthun philippthun marked this pull request as ready for review July 24, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
codex needs_review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add some unit tests to validate the length and stability of the xxhash interface
1 participant
@philippthun