Skip to content

Update Dockerfile to use Python 3.10 and improve build process #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2025

Conversation

ImMin5
Copy link
Member

@ImMin5 ImMin5 commented Apr 30, 2025

Category

  • New feature
  • Bug fix
  • Improvement
  • Refactor
  • etc

Description

  • upgraded python version 3.8 -> 3.10
  • when create core image, replaced PyPI-based spaceone-core install with local source installation using setup.py, with version injection via PACKAGE_VERSION

Known issue

  • We’ll need to upgrade to python3.11 soon.

@ImMin5 ImMin5 added the enhancement New feature or request label Apr 30, 2025
@ImMin5 ImMin5 requested review from stat-kwon, mz-ko and Copilot April 30, 2025 06:27
@ImMin5 ImMin5 self-assigned this Apr 30, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the Dockerfile to use Python 3.10 and improves the build process by switching from a PyPI-based installation of spaceone-core to a local source installation with version injection via setup.py.

  • Upgraded Python version from 3.8 to 3.10
  • Replaced the PyPI spaceone-core install mechanism with a local source installation method
Files not reviewed (1)
  • Dockerfile: Language not supported
Comments suppressed due to low confidence (1)

pkg/pip_requirements.txt:34

  • Ensure that removing 'spaceone-core' from the pip_requirements.txt aligns with the local installation process in setup.py, and that any necessary version management is handled appropriately there.
   -spaceone-core

@ImMin5 ImMin5 merged commit 42e332c into cloudforet-io:master Apr 30, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pass/signedoff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant