forked from segmentio/analytics-java
-
Notifications
You must be signed in to change notification settings - Fork 1
proof of concept for message durability #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
apuig
wants to merge
13
commits into
cloudbees:master
Choose a base branch
from
apuig:poc
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
24fcc00
fix OOM error in test
apuig 8d81420
setup wiremock test
apuig 3d232fa
remove
apuig 82fb908
simple wiremock test
apuig 205e2de
remove callback
apuig af74b24
remove backo, add failsafe
apuig 85ef909
fallback appender
apuig ab780a4
values
apuig 2d06abf
doc
apuig f73e156
stole ReversedLinesFileReader at commons-io:2.18.0
apuig 0d2527e
ReversedLinesFileReader truncate consumed lines
apuig 389875f
truncate lines on resend
apuig ac0bc1f
stop retry on rate limit
apuig File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,60 @@ | ||
```mermaid | ||
|
||
sequenceDiagram | ||
box Data Consolidation | ||
participant ConsolidationService | ||
end | ||
|
||
participant SegmentClient | ||
box HTTP | ||
participant QueueHttp | ||
participant LooperHttp | ||
participant SegmentAPI | ||
end | ||
box File | ||
participant QueueFile | ||
participant WriteFile | ||
participant File | ||
participant WatchFile | ||
end | ||
|
||
activate ConsolidationService | ||
ConsolidationService->>+SegmentClient: enqueue | ||
SegmentClient<<->>QueueHttp: offer | ||
alt QueueHttp overflow | ||
SegmentClient<<->>QueueFile: put | ||
end | ||
SegmentClient->>-ConsolidationService: | ||
deactivate ConsolidationService | ||
|
||
loop consume QueueHttp | ||
LooperHttp->>QueueHttp:take | ||
activate LooperHttp | ||
end | ||
LooperHttp->>SegmentAPI: batchUpload | ||
note over LooperHttp,SegmentAPI: Batch | ||
note over LooperHttp,SegmentAPI: CircuitBreaker and Retry | ||
note over LooperHttp,SegmentAPI: HTTP requests submited to a pool | ||
deactivate LooperHttp | ||
|
||
alt retry exhausted or circuit open | ||
note over LooperHttp: pool threads | ||
LooperHttp->>QueueFile: put | ||
end | ||
|
||
loop consume QueueFile | ||
WriteFile->>QueueFile:take | ||
activate WriteFile | ||
end | ||
WriteFile->>File: write | ||
note over WriteFile: Batch and save file | ||
deactivate WriteFile | ||
|
||
note over WatchFile: check last written | ||
activate WatchFile | ||
loop watch QueueFile | ||
WatchFile->>File: read and remove | ||
WatchFile->>QueueHttp: offer | ||
end | ||
deactivate WatchFile | ||
``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: Looks to be a breaking change. Could we implement the
flush
method based on the new architecture? or at least depreciate it with empty or minimal implementation (warning log)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this method is misleading. Flushing does not guarantee that messages will be delivered.
IMHO the API for segment should be a simple, "hey, there is the message, do your best"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand your point. I'm just thinking about binary compatibility, the upgrade should ideally not require any changes from users.