uperf load driver: add support for fixed rate in TCP/UDP_RR tests #202
+43
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: avasilev <[email protected]>
rsevilla87
reviewed
Sep 29, 2025
pkg/drivers/uperf.go
Outdated
| <flowop type="connect" options="remotehost=%s protocol=%s port=%d"/> | ||
| </transaction> | ||
| <transaction duration="%d"> | ||
| <transaction duration="%d" rate="%d"> |
There was a problem hiding this comment.
What if rate is not set in the config?, I guess is a no-op,
There was a problem hiding this comment.
You are absolutely right! I've added handling for unset rate.
Signed-off-by: avasilev <[email protected]>
Signed-off-by: avasilev <[email protected]>
|
/lgtm |
Signed-off-by: avasilev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
This PR adds a configuration option to specify fixed generation rate for TCP/UDP_RR tests for uperf load driver. This should improve latency measurement precision and reproducibility.
Related Tickets & Documents
Checklist before requesting a review
Testing