Observe cider-doc.edn Java resource files for user-extensible documentation
#863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vemv
commented
Mar 31, 2024
| simple-keyword? | ||
| string?)) | ||
|
|
||
| (defn cider-doc-edn-configs [] |
There was a problem hiding this comment.
TODO - use a cache for not computing the configs every time...
vemv
commented
Apr 1, 2024
| @@ -0,0 +1,2 @@ | |||
| {[cider-doc-edn-example] {:info-provider cider.nrepl.middleware.info-test/sample-info-provider | |||
| :if cider.nrepl.middleware.info-test/sample-info-provider?}} | |||
There was a problem hiding this comment.
Besides from a function, :if could be a set of ns-qualified symbols:
:if #{clojure.core/future com.corp/my-macro ,,, }which would mean: "this rule only applies if the symbol was found within one of these calls".
That would simplify user configs since, I reckon, most people won't want to do parsing themselves.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a draft for now, will be trying it out for a while in a real project, but any ideas welcome.