Code generate filter function for non-unique indexes #3447
+76
−31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Update typescript code generation to generate accessors on non unique indexes. These will use the
filter
function as is the convention in C# and module api.Related to #1387 but doesn't close it.
API and ABI breaking changes
Expected complexity level and risk
2
Testing
Generated the following table:
Into typescript which resulted in the following code for index lookups:
I then manually inserted values into the test_index table and checked that calling the new filter and find functions returned the expected values.