V8: Let a worker thread own the isolate #3401
Merged
+628
−367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centril
force-pushed
the
centril/v8-js-worker-prepare
branch
2 times, most recently
from
6d1cb88 to
c5fca89
Compare
Centril
force-pushed
the
centril/v8-js-worker-2
branch
from
76e951a to
0d2a3ae
Compare
Centril
force-pushed
the
centril/v8-js-worker-2
branch
from
0d2a3ae to
9e55759
Compare
… and owns the isolate. wasm + v8: use the initial instance made when creating the module.
Centril
force-pushed
the
centril/v8-js-worker-2
branch
from
9e55759 to
63b1987
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
JsInstanceto a worker thread to avoid re-making the isolate all the time.JsInstanceEnvbeing potentially unset.Fixes #3460.
API and ABI breaking changes
None
Expected complexity level and risk
3
Testing
Should be covered by exiting tests.