Skip to content

engine: add force index to joins #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

engine: add force index to joins #77

wants to merge 1 commit into from

Conversation

@ShimmerGlass
Copy link
Collaborator

@ShimmerGlass ShimmerGlass commented Jun 2, 2022

innodb sometimes selects a query plan order that is not optimized. we
force the indexes used to remedy that

@ShimmerGlass
engine: add force index to joins
2532d47 
innodb sometimes selects a query plan order that is not optimized. we
force the indexes used to remedy that
jmbass
jmbass approved these changes Jun 13, 2022
View reviewed changes
Copy link
Collaborator

@jmbass jmbass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'd still like to benchmark this on a future PR.

You removed redundant indexes from the DB in this PR, so we might not need to force them any longer.

clems4ever
clems4ever approved these changes Jun 17, 2022
View reviewed changes
Copy link
Owner

@clems4ever clems4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not know that we could force an index. Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clems4ever clems4ever clems4ever approved these changes

@jmbass jmbass jmbass approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ShimmerGlass @clems4ever @jmbass