Skip to content

Conversation

@Perdu
Copy link
Contributor

@Perdu Perdu commented Nov 5, 2025

This might fix some crashes

Perdu added 6 commits November 5, 2025 10:33
This addresses the warnings about using c++14 and c++20 features
Fixes: warning: implicit capture of 'this' via '[=]' is deprecated in C++20 [-Wdeprecated]
Fixes: warning: bitwise operation between different enumeration types
'Qt::Modifier' and 'Qt::Key' is deprecated [-
Wdeprecated-enum-enum-conversion]
that appears with C++20
I prefered using c++ methods instead of increasing buffer size
@Perdu Perdu changed the title Fix various warnings during build Fix warnings during build Nov 5, 2025
@Perdu
Copy link
Contributor Author

Perdu commented Nov 5, 2025

I left this one because I guess this function is used for debugging:

../../../src/library/xlib/xevents.cpp:677:13: warning: 'void libtas::debugEvent(XEvent*)' defined but not used [-Wunused-function]
  677 | static void debugEvent(XEvent *event)
      |             ^~~~~~~~~~

and I'm not exactly sure what to do with this one (that appears because of the move to more recent versions of C++):

../../../src/library/inputs/sdlgamecontroller.cpp:372:44: warning: arithmetic between different enumeration types 'SDL_GameControllerButton' and 'SingleInput::<unnamed enum>' is deprecated [-Wdeprecated-enum-enum-conversion]
  372 |         b.value.hat.hat_mask = bindH[button-SingleInput::BUTTON_DPAD_UP];
      |                                      ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~

@clementgallet clementgallet merged commit f7a3d5f into clementgallet:master Nov 15, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants