Skip to content

Conversation

@jakobrs
Copy link
Contributor

@jakobrs jakobrs commented Jul 8, 2021

Simplifies sockethelpers.cpp, removes the need to place files in the file system, and might make libTAS less likely to break when running multiple instances at the same time.

Possible cons:

  • Might break things if an application closes unrecognised file descriptors for no reason
    • Neither wine, nor gdb does this so it should be fine

Supersedes #420.

@jakobrs jakobrs marked this pull request as draft July 17, 2021 18:55
@jakobrs
Copy link
Contributor Author

jakobrs commented Jul 17, 2021

Want to figure out how to get this to work with lldb, which closes all fds except 0, 1, and 2 by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant