Skip to content

Conversation

@jjpaulino
Copy link
Member

@jjpaulino jjpaulino commented Jul 11, 2019

Solving an issue where the users data in the meta of the page and the _users endpoint wasn't synced.

We'll only handle the properties that shouldn't change and request for the changeable information (like the name or picture) everytime we need.

This is going to work in conjunction with a clay-kiln, amphora-auth and amphora-search change

Issue

@coveralls
Copy link

coveralls commented Jul 11, 2019

Pull Request Test Coverage Report for Build 2376

  • 15 of 15 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 2374: 0.0%
Covered Lines: 4043
Relevant Lines: 4043

💛 - Coveralls

@jjpaulino
Copy link
Member Author

Copy link
Contributor

@manuelurenah manuelurenah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏄

Copy link
Contributor

@pedro-rosario pedro-rosario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done. Do you think we should add the boostrap data of the robot user somewhere?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants