Feat: add support for multiple env variable #5946
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fahri-r
force-pushed
the
5925-envs
branch
2 times, most recently
from
9cfa75c to
736d0ec
Compare
|
Dear reviewer, I don't have any clue why the code can't pass the windows test. Maybe you have a suggestions to make the code better? |
|
Let's finish discussing this in the issue before moving onto a PR, as requested in #5925 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5925
I added envs method that accept Vec for the params.
If user has two environment variables and the first one has a value, then the first one will be picked. But if the first one not have a value, then the second one will be picked.