Skip to content

spf13/cobra: don't use PersistentFlags() #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

spf13/cobra: don't use PersistentFlags() #319

wants to merge 1 commit into from

Conversation

edigaryev
Copy link
Collaborator

The only place where we need them is orchard controller, which shares the --data-dir command-line argument between init and run`.

@edigaryev edigaryev requested a review from fkorotkov as a code owner May 19, 2025 18:29
@edigaryev edigaryev force-pushed the no-persistent-flags branch from a852fd2 to 6669256 Compare May 19, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fkorotkov fkorotkov Awaiting requested review from fkorotkov fkorotkov is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@edigaryev