Skip to content

Disable automaxprocs on Go 1.25+ #1264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Disable automaxprocs on Go 1.25+ #1264

wants to merge 1 commit into from

Conversation

DomParfitt
Copy link
Contributor

@DomParfitt DomParfitt commented Aug 21, 2025 •
edited
Loading

@DomParfitt DomParfitt requested a review from a team as a code owner August 21, 2025 09:15
@notthepoint
Copy link
Contributor

Sorry, for my own understanding, could you explain why we're doing this? 🤔

@DomParfitt
Copy link
Contributor Author

Sorry, for my own understanding, could you explain why we're doing this? 🤔

Yep. Go has a setting called GOMAXPROCS, which is used to set the number of CPU cores available to the Go runtime and has some default behaviour to detect the CPU count when it's not explicitly specified. Unfortunately that CPU detect was not container aware (until recently) so the auto detection didn't work properly when running a Go binary in a container. Because of that we (and pretty much everyone else using Go in production) use a package called automaxprocs, which correctly sets GOMAXPROCS when running in a container. As of Go 1.25 the CPU detection in Go is now container aware, so that package is no longer needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentmmarks brentmmarks brentmmarks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DomParfitt @notthepoint @brentmmarks