fix: add support for top-level parsers [sc-135865]. #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The unit tests will fail until #139 is merged. |
lwatiker
reviewed
May 14, 2025
| TimeStrict ConfigBool `json:"time_strict,omitempty" yaml:"time_strict,omitempty"` | ||
| } | ||
|
|
||
| type Pipeline struct { |
There was a problem hiding this comment.
Should we remove parsers from this section while we're here? If parsers are set, it generates an invalid YAML file.
There was a problem hiding this comment.
Indeed, we should. They were never supported under pipeline to begin with: https://github.com/fluent/fluent-bit/blob/master/src/config_format/flb_cf_yaml.c#L1503.
No idea where that came from. 🤷
Signed-off-by: Phillip Adair Stewart Whelan <[email protected]>
Signed-off-by: Phillip Adair Stewart Whelan <[email protected]>
Signed-off-by: Phillip Adair Stewart Whelan <[email protected]>
pwhelan
force-pushed
the
pwhelan-config-parsers-toplevel
branch
from
949e6ef to
bf150c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add Parsers at the top level with some measure of validation.
What is validated
All the keys are validated and the value of the
formatfield is also validated.What is not validated
time_formattypestime_offset