-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[ENH] CMEK support in storage #5949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Add CMEK plumbing for object storage clients The PR introduces CMEK-awareness into the storage layer by threading an optional Key Changes• Introduce Affected Areas• This summary was automatically generated by @propel-code-bot |
2160d0a to
93c6849
Compare
93c6849 to
394c207
Compare

Description of changes
Summarize the changes made by this PR.
ChromaHttpClientto be used withobject_store, which injects CMEK header according to the extensions fieldCmekenum and addcmek: Option<Cmek>inPutOptions, which will be used for put requests if specifiedTest plan
How are these changes tested?
pytestfor python,yarn testfor js,cargo testfor rustMigration plan
Are there any migrations, or any forwards/backwards compatibility changes needed in order to make sure this change deploys reliably?
Observability plan
What is the plan to instrument and monitor this change?
Documentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs section?