-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[CLN]: remove v1 of garbage collection #5627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
36e614c
to
9a652f8
Compare
Remove Legacy Garbage Collection v1 Code This PR removes the original (v1) implementation of garbage collection logic from the codebase, including related orchestrators, operators, tests, and support code. The system is now fully migrated to the v2 garbage collection implementation, simplifying the codebase and eliminating duplicate/dead code across several modules. The removal includes substantial refactoring of type definitions, orchestrator handling, and extensive deletions from test and property test code, as well as API/CLI surface changes to fully deprecate v1 pathways. Key Changes• Deleted the entire Affected Areas• This summary was automatically generated by @propel-code-bot |
9a652f8
to
2b14c5c
Compare
Description of changes
Removes a bunch of dead code.
Test plan
How are these changes tested?
pytest
for python,yarn test
for js,cargo test
for rustMigration plan
Are there any migrations, or any forwards/backwards compatibility changes needed in order to make sure this change deploys reliably?
Observability plan
What is the plan to instrument and monitor this change?
Documentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs section?