(#211) Ensure direct publishers respect context cancellation #2260
Conversation
vjanelle
commented
Aug 6, 2025
vjanelle
commented
- Add context cancellation checks to core publishing methods (PublishRaw, PublishRawMsg) in choria/connection.go.
- Update federation egest, stream adapter, and submission spool to check context before publishing.
- Improve client publisher to check context before publishing and connecting.
- Add context cancellation checks to core publishing methods (PublishRaw, PublishRawMsg) in choria/connection.go. - Update federation egest, stream adapter, and submission spool to check context before publishing. - Improve client publisher to check context before publishing and connecting.
ugh >.> |
broker/adapter/streams/output.go
Outdated
| defer obs.ObserveDuration() | ||
| defer func() { workqlen.Set(float64(len(sc.work))) }() | ||
|
|
||
| select { |
There was a problem hiding this comment.
I think all these can be just checking if ctx.Error is nil?
hard to say if this will really help unless the nats.go calls took contexts
There was a problem hiding this comment.
Less code, same effect - non-blocking.
And yeah, probably not immediately useful.
There was a problem hiding this comment.
@ripienaar the nats client takes custom dialers so we could use net.DialContext?
There was a problem hiding this comment.
That would only be for making the initial connection I think?
There was a problem hiding this comment.
Publishing tends to happen into a buffer in the client it wouldn’t block. The only really blocking thing is nc.Request
2 participants
