(#2204) container images typically don't have systemd, this should allow the choria package to be installed on those images. #2203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…choria package to be installed on those images.
TomRitserveldt
force-pushed
the
feature/container-support
branch
from
ba73b26 to
1591eb4
Compare
smortex
reviewed
Oct 22, 2024
Member
smortex
left a comment
smortex
left a comment
There was a problem hiding this comment.
Well, I trend to think that container images should not have more that a binary and its required libs (so no shell, no apt, etc)… 😄
In any case, don't mix tabs and spaces (stick to tabs to match what is used in these files), and make sure the last line has its trailing '\n' (it is probably wise to configure your editor to do it for you).
TomRitserveldt
force-pushed
the
feature/container-support
branch
from
d303365 to
21c054f
Compare
Member
|
Please review the contributing guide and follow that, we need issues filed and specific forms commit messages. |
Member
|
@TomRitserveldt you planning to update this or shall I close it? thanks |
vjanelle
changed the title
Member
|
@ripienaar could potentially use this in the future so created a issue for them. |
Member
|
Also need signed commits :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.