Add worker-monitor service to Docker Compose files #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a new service, worker-monitor, to both docker-compose-dev.yaml and docker-compose.yaml. The service uses the marble-worker-monitor container and is configured with environment variables for database connection and basic authentication. It also specifies a dependency on the db service.
ghost
requested a review
from 
| - ${HOST_APP_PORT:-3000}:${APP_PORT:-8080} | ||
| environment: | ||
| <<: [*shared-env, *frontend-env] | ||
| worker-monitor: |
There was a problem hiding this comment.
I'm wondering if we should recommend installation of this tool in a prod environment. Do you see any security risks @apognu ?
| - ${WORKER_MONITOR_PORT:-8081}:8080 | ||
| environment: | ||
| DATABASE_URL: "postgresql://postgres:${PG_PASSWORD:-changeme}@db:${PG_PORT:-5432}/marble" | ||
| RIVER_BASIC_AUTH_USER: ${RIVER_BASIC_AUTH_USER:-} |
There was a problem hiding this comment.
if we expose those configuration variables (also WORKER_MONITOR_PORT above), we should define and document them in the .env.example file. If I'm not getting this backwards (honestly it's tricky to remember), only env vars interpolated from the .env file are used in those ${ENV:-} blocks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a new service, worker-monitor, to both docker-compose-dev.yaml and docker-compose.yaml. The service uses the marble-worker-monitor container and is configured with environment variables for database connection and basic authentication. It also specifies a dependency on the db service.
Description
Introduce a new service for monitoring background tasks using River UI. The service displays the task history and allows interaction with the job queue, including cancelling or retrying tasks. It also provides debugging capabilities by showing error messages and argument values for each task.
Changes
docker-compose.yamldocker-compose-dev.yamlAdditional Information
N/A
Screenshots
Checklist