build: update rand to 0.9 #7352
Merged
+22
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already have both rand 0.8 and rand 0.9 in our dependency tree. We still need rand 0.8 because public APIs of rPGP 0.17.0 and Iroh 0.35.0 use rand 0.8 types in public APIs, so it is imported as rand_old.
link2xt
force-pushed
the
link2xt/rand-09
branch
from
94649a0 to
fe2ec07
Compare
iequidoo
approved these changes
Oct 26, 2025
| pin-project = "1" | ||
| qrcodegen = "1.7.0" | ||
| quick-xml = { version = "0.38", features = ["escape-html"] } | ||
| rand-old = { package = "rand", version = "0.8" } |
There was a problem hiding this comment.
rand-0-8 may be more clear, but doesn't matter much, probably we're not going to have multiple old versions
There was a problem hiding this comment.
Once rPGP gets rpgp/rpgp#573 and Iroh 1.0 is released we will be able to get rid of rand-old, so it hopefully does not stay for too long.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already have both rand 0.8 and rand 0.9
in our dependency tree.
We still need rand 0.8 because
public APIs of rPGP 0.17.0 and Iroh 0.35.0
use rand 0.8 types in public APIs,
so it is imported as rand_old.