Receiving of re-sent deleted messages (#7115) #7131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iequidoo
force-pushed
the
iequidoo/one-shot-tombstones
branch
3 times, most recently
from
e670205 to
18dede1
Compare
iequidoo
changed the title
iequidoo
force-pushed
the
iequidoo/one-shot-tombstones
branch
from
18dede1 to
ca5b098
Compare
…anymore (#7115) This allows to receive deleted messages again if they're re-sent: - After a manual deletion, - If both DeleteServerAfter and DeleteDeviceAfter are set, w/o waiting for 2 days when stale tombstones are GC-ed. This is particularly useful for webxdc. If only DeleteDeviceAfter is set though, this changes nothing and maybe a separate fix is needed. This may also greately reduce the db size for some bots which receive and immediately delete many messages. Also insert a tombstone to the db if a deletion request (incl. sync messages) can't find `rfc724_mid`. This may happen in case of message reordering and the deleted message mustn't appear when it finally arrives.
Before, locally deleted messages (because of DeleteDeviceAfter set or external deletion requests) couldn't be received if they're re-sent because tombstones prevented that forever. This led to locally deleted webxdcs being unrecoverable.
iequidoo
force-pushed
the
iequidoo/one-shot-tombstones
branch
from
ca5b098 to
308044e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps #7115.
Not sure about the second commit because it breaks the scenario described in
ephemeral.rs:But the first one shouldn't make harm even for Gmail (tested it with my account with "Watch Sent Folder" set) which copies sent messages to Sent because if the user deletes the message, either it has already appeared on both mailboxes or hasn't really sent yet, i.e. it's quite hard to catch a race and see that the message reappears after deletion, at least i haven't succeeded with this.