Skip to content

Support 17763 #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support 17763 #300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CharacterMap/CharacterMap/CharacterMap.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
<TargetPlatformIdentifier>UAP</TargetPlatformIdentifier>
<!-- Do Not Update to Windows 11 SDK -->
<TargetPlatformVersion Condition=" '$(TargetPlatformVersion)' == '' ">10.0.20348.0</TargetPlatformVersion>
<TargetPlatformMinVersion>10.0.19041.0</TargetPlatformMinVersion>
<TargetPlatformMinVersion>10.0.17763.0</TargetPlatformMinVersion>
<MinimumVisualStudioVersion>14</MinimumVisualStudioVersion>
<LangVersion>10.0</LangVersion>
<FileAlignment>512</FileAlignment>
Expand Down
10 changes: 8 additions & 2 deletions CharacterMap/CharacterMap/Views/MainPage.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,10 @@ public MainPage(MainViewModelArgs args)
if (ViewModel.IsSecondaryView is false)
{
_uiSettings.ColorValuesChanged += OnColorValuesChanged;
_uiSettings.AnimationsEnabledChanged += OnAnimationsEnabledChanged;
if (Windows.Foundation.Metadata.ApiInformation.IsEventPresent(_uiSettings.GetType().Name, "AnimationsEnabledChanged"))
{
_uiSettings.AnimationsEnabledChanged += OnAnimationsEnabledChanged;
}
};

FilterCommand = new RelayCommand<object>(e => OnFilterClick(e));
Expand Down Expand Up @@ -211,7 +214,10 @@ protected override void OnUnloaded(object sender, RoutedEventArgs e)
// For Secondary Views, cleanup EVERYTHING to allow the view to get
// dropped from memory
_uiSettings.ColorValuesChanged -= OnColorValuesChanged;
_uiSettings.AnimationsEnabledChanged -= OnAnimationsEnabledChanged;
if (Windows.Foundation.Metadata.ApiInformation.IsEventPresent(_uiSettings.GetType().Name, "AnimationsEnabledChanged"))
{
_uiSettings.AnimationsEnabledChanged -= OnAnimationsEnabledChanged;
}
Messenger.UnregisterAll(this);
this.Bindings.StopTracking();
ViewModel.PropertyChanged -= ViewModel_PropertyChanged;
Expand Down