dlopen: Make the dynamic loading internals largely locale-agnostic #27859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, the code would do things like explicitly synchronize on e.g., 'Locales[0]'. Now, the code will synchronize 'on this' instead. While here, improve/remove comments and add a new helper routine. Signed-off-by: David Longnecker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the dynamic loading internals by making the code locale-agnostic instead of explicitly synchronizing on e.g.,
Locales[0].It also adjusts loaded binaries so that they live on the locale where
createis first called rather than always being allocated onLocales[0]. It's unclear to me what benefit this might have (other than reducing contention on arguably the most contested locale in a program), but it also didn't feel right to have an explicitLocales[0]either. I go back and forth on whether or not binaries should be privatized, but ultimately it doesn't seem worth the cost (unlike a procedure pointer cache, which is accessed much more frequently).While here, I've tweaked and removed some comments, opting to remove some that I found to be redundant. I've also added some more TODOs.