Refactor CoLic with strategy pattern #107
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Graal backends face evolution issues. This refactor implements the strategy pattern in the CoLic backend to prevent these issues from occurring. These issues were initially pointed out in #89, and we introduced our proposed solution in #104.
This PR only includes the refactor of CoLic to keep changes easy to review, however, refactorings of the other backends are ready as well. Any feedback acquired here will be processed there as well.
Note that this PR also resolves issues in the CI pipeline. If desired, we can make a separate PR for this.
The original one had issues with the Fossology and Ubuntu versions. We removed Ruby as well, as the version of Linguist pulled there caused errors.
@valeriocos recommended to ping @sduenas, @zhquan and @vchrombie.